chore: annotate errors returned from NewFromStat() with the file path #5657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
reviewed
Jan 15, 2025
cache/contenthash/filehash.go
Outdated
| @@ -46,7 +47,7 @@ func NewFromStat(stat *fstypes.Stat) (hash.Hash, error) { | |||
| fi := &statInfo{stat} | |||
| hdr, err := tar.FileInfoHeader(fi, stat.Linkname) | |||
| if err != nil { | |||
| return nil, err | |||
| return nil, errors.Wrapf(err, "failed to stat file %s", stat.Path) | |||
There was a problem hiding this comment.
"failed to checksum file" (or hash), as this error may not come from stat.
There was a problem hiding this comment.
Makes sense, thanks! I've updated it, PTAL.
crazy-max
requested changes
Jan 15, 2025
fiam
force-pushed
the
alberto/annotate-new-from-stat-error
branch
from
4267454 to
3e41eee
Compare
Sure, thanks! I've squased them into a single commit. PTAL |
Otherwise it is very tricky to understand which file produced the error. Should help with docker/for-win#14083 Signed-off-by: Alberto Garcia Hierro <[email protected]>
fiam
force-pushed
the
alberto/annotate-new-from-stat-error
branch
from
3e41eee to
8d83d36
Compare
crazy-max
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise it is very tricky to understand which file produced the error.
Should help with docker/for-win#14083